Eli Mesika has posted comments on this change. Change subject: engine: Alphanumeric sorting order for db query results (no bz) ......................................................................
Patch Set 1: rami wrote: >explicit index scan is not useful in small tables like rhevm >uses Vms is a view that joins : vm_static,vm_dynamic, vm_statistics , vds_groups and storage_pool those are not small tables , actually , this view may have millions of records as its result set. and even we are getting only the first page you will have to scan all to compute your regular expression > In practice, I've tested the patch on env with more than 1000 data centers and how many hosts & vms in each host did you have do a real test and turn the pg analysis on and you will see from the query plan what is the difference BTW 1) what about other non-search queries returning results to the client , how does your patch addresses that ??? 2) what about queries that fetch data from vdsm (for example getting the list of available images of an attached ISO domain) , how are you going to address that ??? 3) Active directory / LDAP searches , how are you going to support that ??? >From the time we will support the feature you had suggested, all above will be >considered as bugs !!! -- To view, visit http://gerrit.ovirt.org/5079 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice3ae8b9f897690e777dc53b659359e5cefcd292 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Rami Vaknin <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Rami Vaknin <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
