Alon Bar-Lev has posted comments on this change. Change subject: aaa: fix coverity issues ......................................................................
Patch Set 2: (5 comments) http://gerrit.ovirt.org/#/c/27397/2/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/SimpleLdapTemplateWrapper.java File backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/SimpleLdapTemplateWrapper.java: Line 48: } else { Line 49: userDNSb.append("uid=").append(userName).append(",cn=Users").append(",cn=Accounts"); Line 50: } Line 51: Line 52: if (baseDN != null && !baseDN.isEmpty()) { StringUtils isEmpty? Line 53: String dcDN = getDcDN(baseDN); Line 54: if (!dcDN.isEmpty()) { Line 55: userDNSb.append(",").append(dcDN); Line 56: } http://gerrit.ovirt.org/#/c/27397/2/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomains.java File backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomains.java: Line 152: } Line 153: } Line 154: Line 155: private String convertStreamToString(InputStream is) { Line 156: return new Scanner(is, Charset.forName("UTF-8").toString()).useDelimiter("\\A").next().replace("\n", ""); bad java! Line 157: } Line 158: Line 159: public String getConfigValue(String engineConfigExecutable, String engineConfigProperties, ConfigValues enumValue) Line 160: throws IOException, Line 318: return value; Line 319: } Line 320: Line 321: private String readPasswordFile(String passwordFile) throws FileNotFoundException, IOException { Line 322: try (BufferedReader bufferedReader = new BufferedReader(new FileReader(passwordFile))) { no... you must use InputStreamReader with charset Line 323: String readLine = bufferedReader.readLine(); Line 324: return readLine; Line 325: } Line 326: } http://gerrit.ovirt.org/#/c/27397/2/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/JndiAction.java File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/JndiAction.java: Line 101 Line 102 Line 103 Line 104 Line 105 move this above the try? Line 126: + " Failed to query rootDSE in order to get the baseDN. Could not query for user " Line 127: + userName + " in domain " + domainName); Line 128: } Line 129: } finally { Line 130: if (ctx != null) { and remove condition? Line 131: ctx.close(); Line 132: } Line 133: } Line 134: } catch (CommunicationException ex) { -- To view, visit http://gerrit.ovirt.org/27397 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I057929e0f2dc7672bc5d06457d14c548f4726112 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
