Alon Bar-Lev has posted comments on this change. Change subject: aaa: fix coverity issues ......................................................................
Patch Set 3: OK, code is nice! now, let's discuss improvements :) 1. move all configuration to config file, update vdc_options on startup. this will allow starting service when database is down, and have single place for configuration. 2. periodic update sessions within database instead of when packet is accepted, this will reduce load and make service more predictable. 3. survive database down/up by reading all vdsm ids addresses and session status when database connection established. then when database connection is established we sync missing entries within map and in next periodic update (2) we update the database with these that new or expired. -- To view, visit http://gerrit.ovirt.org/27397 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I057929e0f2dc7672bc5d06457d14c548f4726112 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
