Roy Golan has posted comments on this change. Change subject: core: present the guest cpu toplogy ......................................................................
Patch Set 3: (3 comments) http://gerrit.ovirt.org/#/c/27243/3/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java: Line 1742: public void setActualCpuTopology(String actualCpuTopology) { Line 1743: getDynamicData().setActualCpuTopology(actualCpuTopology); Line 1744: } Line 1745: Line 1746: public String getActualCpuTopology() { > i thought its a number, no? why string? what vdsm return? Vinzenz, Michal and I where talking about some kind of representing the whole topology, /online/offline/ 2/1 but currently it was decided to report only the online. anyhow, I'll double check with Vinzenz. if its not going to change I'll change to int Line 1747: return getDynamicData().getActualCpuTopology(); Line 1748: } http://gerrit.ovirt.org/#/c/27243/3/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGeneralModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGeneralModel.java: Line 279: private String actualCpuTopology; Line 280: Line 281: public String getActualCpuTopology() { Line 282: if (StringHelper.isNullOrEmpty(actualCpuTopology) || actualCpuTopology.equals("-1")) { //$NON-NLS-1$ Line 283: return "N/A"; //$NON-NLS-1$ > please use notAvailableLabel constant Done Line 284: } else { Line 285: return actualCpuTopology; Line 286: } Line 287: } http://gerrit.ovirt.org/#/c/27243/3/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java File frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java: Line 254: Line 255: @DefaultMessage("{0} ({1} Socket(s), {2} Core(s) per Socket)") Line 256: String cpuInfoLabel(int numberOfCpus, int numberOfSockets, int numberOfCpusPerSocket); Line 257: Line 258: @DefaultMessage("{0}") > please remove Done Line 259: String guestActualCpuTopologyLabel(String guestActualCpuTopology); Line 260: Line 261: @DefaultMessage("{0} (from Storage Domain {1})") Line 262: String templateDiskDescription(String diskAlias, String storageDomainName); -- To view, visit http://gerrit.ovirt.org/27243 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7aa88e18ba620980ee31a633deaa3345298300e2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
