Omer Frenkel has posted comments on this change.

Change subject: core: present the guest cpu toplogy
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/27243/3/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java:

Line 1742:     public void setActualCpuTopology(String actualCpuTopology) {
Line 1743:         getDynamicData().setActualCpuTopology(actualCpuTopology);
Line 1744:     }
Line 1745: 
Line 1746:     public String getActualCpuTopology() {
i thought its a number, no? why string? what vdsm return?
Line 1747:         return getDynamicData().getActualCpuTopology();
Line 1748:     }


-- 
To view, visit http://gerrit.ovirt.org/27243
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7aa88e18ba620980ee31a633deaa3345298300e2
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to