Alon Bar-Lev has posted comments on this change.

Change subject: packaging: setup: Removing build-conf files on failure
......................................................................


Patch Set 13:

(2 comments)

http://gerrit.ovirt.org/#/c/27167/13/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py
File 
packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py:

Line 678:             )
Line 679: 
Line 680:             self._workaroundUsersNullPaswords(self._users)
Line 681:         except:
Line 682:             if buildconfexisted:
if not?
Line 683:                 shutil.rmtree(
Line 684:                     oreportscons.FileLocations.
Line 685:                     OVIRT_ENGINE_REPORTS_BUILDOMATIC_CONFIG,
Line 686:                 )


Line 997:                         addition = libxml2.parseDoc(
Line 998:                             '''
Line 999:                                 <folder>%s</folder>
Line 1000:                             ''' % self.environment[
Line 1001:                             oreportscons.JasperEnv.THEME
?
Line 1002:                             ]
Line 1003:                         )
Line 1004:                         xml.xpath.xpathEval('/folder')[0].addChild(
Line 1005:                             addition.getRootElement()


-- 
To view, visit http://gerrit.ovirt.org/27167
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2507ea0c6ecd6d0a69f56d0693fcafd21f58992f
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com>
Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to