Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: Removing build-conf files on failure ......................................................................
Patch Set 10: (2 comments) nice! http://gerrit.ovirt.org/#/c/27167/10/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py: Line 551: ), Line 552: ) Line 553: def _export(self): Line 554: config = self._jasperConfiguration() Line 555: configexisted = None please set as False for booleans... Line 556: self._quartzprops = os.path.join(self._temproot, 'quartzprops') Line 557: Line 558: if ( Line 559: os.path.exists( Line 680: except Exception as e: Line 681: if configexisted: Line 682: shutil.rmtree( Line 683: OVIRT_ENGINE_REPORTS_BUILDOMATIC_CONFIG, Line 684: ) this should be: except: if... raise Line 685: Line 686: @plugin.event( Line 687: stage=plugin.Stages.STAGE_MISC, Line 688: name=oreportscons.Stages.DB_SCHEMA, -- To view, visit http://gerrit.ovirt.org/27167 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2507ea0c6ecd6d0a69f56d0693fcafd21f58992f Gerrit-PatchSet: 10 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
