Eli Mesika has posted comments on this change.

Change subject: core: Support detach Storage Domain with disks.
......................................................................


Patch Set 10:

(1 comment)

http://gerrit.ovirt.org/#/c/24286/10/packaging/dbscripts/disk_images_sp.sql
File packaging/dbscripts/disk_images_sp.sql:

Line 153: END; $procedure$
Line 154: LANGUAGE plpgsql;
Line 155: 
Line 156: 
Line 157: Create or replace FUNCTION GetAllForStorageDomain(v_storage_domain_id 
UUID)
Should be defined as STABLE
Line 158: RETURNS SETOF images_storage_domain_view
Line 159:    AS $procedure$
Line 160: BEGIN
Line 161:       RETURN QUERY SELECT i.*


-- 
To view, visit http://gerrit.ovirt.org/24286
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I971fe6acd4a2667a09487c5e1108cf7c759587f1
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to