Tal Nisan has posted comments on this change. Change subject: core: Support detach Storage Domain with disks. ......................................................................
Patch Set 11: (1 comment) http://gerrit.ovirt.org/#/c/24286/11/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java: Line 220: Line 221: /** Line 222: * Remove all related entities of the Storage Domain from the DB. Line 223: */ Line 224: private void removeEntitiesFromStorageDomain(final List<VM> vmsForStorageDomain, I don't really like this signature, why not use List<VmBase> and call the method twice? Will result in two transactions indeed but still it's more elegant than calling it once for two kinds of entities which has the same base anyway... Line 225: final List<VmTemplate> vmTemplatesForStorageDomain, Line 226: final Guid storageDomainId) { Line 227: TransactionSupport.executeInNewTransaction(new TransactionMethod<Object>() { Line 228: @Override -- To view, visit http://gerrit.ovirt.org/24286 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I971fe6acd4a2667a09487c5e1108cf7c759587f1 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
