Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: iSCSI support ......................................................................
Patch Set 17: (1 comment) http://gerrit.ovirt.org/#/c/26501/17/src/plugins/ovirt-hosted-engine-setup/sanlock/lockspace.py File src/plugins/ovirt-hosted-engine-setup/sanlock/lockspace.py: Line 123: os.chown( Line 124: agent_data_dir, Line 125: self.environment[ohostedcons.VDSMEnv.VDSM_UID], Line 126: self.environment[ohostedcons.VDSMEnv.KVM_GID] Line 127: ) Does this work on NFS where backendUserContext drops root privileges? Line 128: # Update permissions on the lockspace directory to 0755 Line 129: os.chmod(agent_data_dir, Line 130: stat.S_IRWXU | stat.S_IRGRP | stat.S_IXGRP) Line 131: -- To view, visit http://gerrit.ovirt.org/26501 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide79a130b730d95d3545dcfb80b1b01dfeaf2b12 Gerrit-PatchSet: 17 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmosk...@redhat.com> Gerrit-Reviewer: Lev Veyde <lve...@gmail.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
