Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: iSCSI support ......................................................................
Patch Set 15: (1 comment) http://gerrit.ovirt.org/#/c/26501/15/src/plugins/ovirt-hosted-engine-setup/sanlock/lockspace.py File src/plugins/ovirt-hosted-engine-setup/sanlock/lockspace.py: Line 105: # Create storage for he metadata and sanlock lockspace Line 106: # 1MB is good for 2000 clients when the block size is 512B Line 107: # if it's a block device like iscsi it needs root privileges Line 108: # to create volume using lvcreate and that's why we have Line 109: # the backendUserContext magic up there will the created volume be accessible by vdsm:kvm ? Line 110: created = backend.create({ Line 111: lockspace + '.lockspace': 1024*1024*backend.blocksize/512, Line 112: lockspace + '.metadata': md_size Line 113: }) -- To view, visit http://gerrit.ovirt.org/26501 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide79a130b730d95d3545dcfb80b1b01dfeaf2b12 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmosk...@redhat.com> Gerrit-Reviewer: Lev Veyde <lve...@gmail.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
