Moti Asayag has posted comments on this change. Change subject: core,userportal,webadmin: added singular variant for messages. ......................................................................
Patch Set 5: (4 comments) Please note couple of Yevgeny's comments are not replied (from earlier patchset) http://gerrit.ovirt.org/#/c/25736/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/RemoveProviderCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/RemoveProviderCommand.java: Line 113: } Line 114: Line 115: protected VdcBllMessages providerNetworkUsedValidationMessage(int numberOfNetworks) { Line 116: boolean singular = numberOfNetworks == 1; Line 117: if (singular) { you could inline the condition Line 118: return VdcBllMessages.ACTION_TYPE_FAILED_PROVIDER_NETWORKS_USED_ONCE; Line 119: } else { Line 120: return VdcBllMessages.ACTION_TYPE_FAILED_PROVIDER_NETWORKS_USED_MULTIPLE_TIMES; Line 121: } http://gerrit.ovirt.org/#/c/25736/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkValidator.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkValidator.java: Line 161: singular you could inline the condition http://gerrit.ovirt.org/#/c/25736/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VnicProfileValidator.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VnicProfileValidator.java: Line 103: ) you could inline the condition http://gerrit.ovirt.org/#/c/25736/5/backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties: Line 432: ACTION_TYPE_FAILED_VNIC_PROFILE_IN_MANY_USES The plural and the singular messages contain the same text. Shouldn't the singular and plural form contain the text as suggested on: https://bugzilla.redhat.com/show_bug.cgi?id=997197#c2 -- To view, visit http://gerrit.ovirt.org/25736 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2410b2c75380a78ffc24d142987e684182bf5dc9 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
