Moti Asayag has posted comments on this change. Change subject: core,userportal,webadmin: added singular variant for messages. ......................................................................
Patch Set 5: (3 comments) Please revert any webadmin translation file which isn't frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties that comply with: frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_*.properties http://gerrit.ovirt.org/#/c/25736/5/frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties File frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties: Line 465 Line 466 Line 467 Line 468 Line 469 Since this resource file (and it derivative) are relevant to UserPortal which doesn't support network level actions, please remove those keys and messages from this file. (They shouldn't be added to this file at first place). Also, please revert any changes to the other user-portal resources files. The translation files are managed by zanata. Line 493 Line 494 Line 495 Line 496 Line 497 same Line 552 Line 553 Line 554 Line 555 Line 556 same -- To view, visit http://gerrit.ovirt.org/25736 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2410b2c75380a78ffc24d142987e684182bf5dc9 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
