Shirly Radco has posted comments on this change. Change subject: reports: br22 report - added comments to queries ......................................................................
Patch Set 8: (3 comments) http://gerrit.ovirt.org/#/c/24801/8/packaging/ovirt-reports/resources/Reports/Executive/host_os_break_down_BR22_files/host_os_break_down_BR22_jrxml.data File packaging/ovirt-reports/resources/Reports/Executive/host_os_break_down_BR22_files/host_os_break_down_BR22_jrxml.data: Line 76: ON ( Line 77: v3_4_configuration_history_hosts.history_id = Line 78: stats_hosts.host_configuration_version Line 79: ) Line 80: INNER JOIN v3_4_configuration_history_hosts a > should be indented with one less tab Done Line 81: ON ( Line 82: a.host_id = Line 83: stats_hosts.host_id Line 84: ) Line 203: ON ( Line 204: v3_4_configuration_history_hosts.history_id = Line 205: stats_hosts.host_configuration_version Line 206: ) Line 207: INNER JOIN v3_4_configuration_history_hosts a > should be indented with one less tab Done Line 208: ON ( Line 209: a.host_id = Line 210: stats_hosts.host_id Line 211: ) Line 258: v3_4_configuration_history_hosts.host_os, Line 259: 'Unknown' Line 260: ) Line 261: ) Line 262: a > AS a* Done Line 263: RIGHT OUTER JOIN calendar b Line 264: ON ( Line 265: a.history_datetime = b.$P!{calendar_column} Line 266: ) -- To view, visit http://gerrit.ovirt.org/24801 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I377ed12395c144d814af6c86212bf4755f0bb3aa Gerrit-PatchSet: 8 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sra...@redhat.com> Gerrit-Reviewer: Shirly Radco <sra...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
