Yaniv Dary has posted comments on this change. Change subject: reports: br22 report - added comments to queries ......................................................................
Patch Set 9: (5 comments) http://gerrit.ovirt.org/#/c/24801/9/packaging/ovirt-reports/resources/Reports/Executive/host_os_break_down_BR22_files/full+details.jrxml.data File packaging/ovirt-reports/resources/Reports/Executive/host_os_break_down_BR22_files/full details.jrxml.data: Line 78: WHEN $P{P_Period} = 3 Line 79: THEN CAST ( Line 80: CAST ( $P{P_Start_Date} AS date ) + Line 81: interval '1 year' - interval '1 day' AS date Line 82: ) need to be inline with the THEN Line 83: END Line 84: AS end_date, Line 85: ( Line 86: SELECT DISTINCT Line 97: FROM enum_translator Line 98: WHERE language_code = $P{P_Locale} Line 99: ) Line 100: AS enum_translator_localized Line 101: ON ( Why is there tabs here? Line 102: enum_translator_localized.enum_type = Line 103: enum_translator_default.enum_type Line 104: AND enum_translator_localized.enum_key = Line 105: enum_translator_default.enum_key http://gerrit.ovirt.org/#/c/24801/9/packaging/ovirt-reports/resources/Reports/Executive/host_os_break_down_BR22_files/host_os_break_down_BR22_jrxml.data File packaging/ovirt-reports/resources/Reports/Executive/host_os_break_down_BR22_files/host_os_break_down_BR22_jrxml.data: Line 178: -- If "Period" equals to "Daily" then Line 179: -- the "calendar_column" parameter is equal Line 180: -- to "the_datetime" else "the_date" Line 181: $P!{calendar_column} AS the_date, Line 182: COALESCE ( Please change to single space after COALESCE Line 183: os_type, Line 184: MAX ( os_type ) over (partition by 1), Line 185: '' Line 186: ) Line 215: FROM v3_4_configuration_history_clusters Line 216: WHERE Line 217: v3_4_configuration_history_clusters.datacenter_id = Line 218: CAST ( $P{P_DataCenter_ID} AS uuid ) Line 219: ) should be indented by one less tab Line 220: AND v3_4_configuration_history_hosts.cluster_id = Line 221: CASE $P{P_Cluster_ID} Line 222: WHEN '11111111-1111-1111-1111-111111111111' Line 223: THEN v3_4_configuration_history_hosts.cluster_id Line 258: v3_4_configuration_history_hosts.host_os, Line 259: 'Unknown' Line 260: ) Line 261: ) AS a Line 262: RIGHT OUTER JOIN calendar b Should be indented by one more tab Line 263: ON ( Line 264: a.history_datetime = b.$P!{calendar_column} Line 265: ) Line 266: WHERE -- To view, visit http://gerrit.ovirt.org/24801 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I377ed12395c144d814af6c86212bf4755f0bb3aa Gerrit-PatchSet: 9 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sra...@redhat.com> Gerrit-Reviewer: Shirly Radco <sra...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
