Moti Asayag has posted comments on this change.

Change subject: engine: Remove update functionality from AttachNetworkToCluster
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.ovirt.org/#/c/24902/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworkToVdsGroupCommand.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworkToVdsGroupCommand.java:

Line 60:     }
Line 61: 
Line 62:     @Override
Line 63:     protected void executeCommand() {
Line 64:         TransactionSupport.executeInNewTransaction(new 
TransactionMethod<Void>() {
Be aware of 
http://gerrit.ovirt.org/#/c/26256/9/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworkToVdsGroupCommand.java,cm

if this patch is going to be merge last, revert the above patch changes in 
regards to this class.
Line 65: 
Line 66:             @Override
Line 67:             public Void runInTransaction() {
Line 68:                 attachNetwork(getVdsGroupId(), getNetworkCluster(), 
getNetwork());


-- 
To view, visit http://gerrit.ovirt.org/24902
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7aae709dfa0f55ab78d9c1f3caddf75c9d27deb9
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to