Moti Asayag has posted comments on this change. Change subject: engine: Remove update functionality from AttachNetworkToCluster ......................................................................
Patch Set 5: (2 comments) http://gerrit.ovirt.org/#/c/24902/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworkToVdsGroupCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworkToVdsGroupCommand.java: Line 142: } Line 143: return true; Line 144: } Line 145: Line 146: private boolean noConflictingNetwork() { perhaps networkNotAttachedToCluster() ? since it describes the nature of the conflict. Line 147: if (networkExists()) { Line 148: return failCanDoAction(VdcBllMessages.NETWORK_ALREADY_ATTACHED_TO_CLUSTER); Line 149: } Line 150: return true; Line 145: Line 146: private boolean noConflictingNetwork() { Line 147: if (networkExists()) { Line 148: return failCanDoAction(VdcBllMessages.NETWORK_ALREADY_ATTACHED_TO_CLUSTER); Line 149: } please add a space line Line 150: return true; Line 151: } Line 152: Line 153: private boolean networkExists() { -- To view, visit http://gerrit.ovirt.org/24902 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7aae709dfa0f55ab78d9c1f3caddf75c9d27deb9 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
