Yair Zaslavsky has posted comments on this change. Change subject: core: Enhancing the quota to apply to internal commands ......................................................................
Patch Set 4: IMHO, CommandBase is becoming a "big pile of junk" (sorry for the harsh words :) ). I would be glad if we think of how not to add additional stuff to it , if possible. With using an interface, you can have a class that implements the required quota logic (let's say - some QuoteHelper class), and have it accept a command as parameter (this is just a rough thought, i'm sure u can think of something better). Not sure I understand your response about inheritence - if x extends y , it doesnt necessarily mean x will get this characteristic as well? -- To view, visit http://gerrit.ovirt.org/26654 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e4a050cb845165630741c4857f0ba7de12fa60e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kobi Ianko <k...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Kobi Ianko <k...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
