Kobi Ianko has posted comments on this change. Change subject: core: Enhancing the quota to apply to internal commands ......................................................................
Patch Set 3: The purpose of the annotation is to mark the command as Quota related. We can do this with an interface as well(Like java did with Serializable) The logic is in the base class (CommandBase), and if a developer would like to add another internal quota related command he only needs to mark it. that looks like a good place for the code (IMO) Now, the question is how to mark the command ? Yair, you have added an important comment on the inheritance, I admit that I did not fully check that :) First: I think inherited command should not take the Quota mark, because it could be logically completely different command. Second: The annotation solution will support that (using ClassCommand.isAnnotationPresent(QuotaAnno.class) ). -- To view, visit http://gerrit.ovirt.org/26654 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e4a050cb845165630741c4857f0ba7de12fa60e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kobi Ianko <k...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Kobi Ianko <k...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
