Darshan N has posted comments on this change. Change subject: gluster: Added a plugin under gluster for nrpe configuration. ......................................................................
Patch Set 5: (3 comments) http://gerrit.ovirt.org/#/c/26956/5/ChangeLog File ChangeLog: Line 2: Line 3: ????-??-?? - Version 1.2.1 Line 4: Line 5: * vdsmhooks: use short distribution name as suffix. Line 6: * gluster: nrpe: add nrpe configuration support. > pleae remove trailing space, and andd rhbz# Done Line 7: Line 8: 2014-03-28 - Version 1.2.0 Line 9: Line 10: 2014-01-20 - Version 1.2.0_beta http://gerrit.ovirt.org/#/c/26956/5/src/plugins/ovirt-host-deploy/gluster/nrpe.py File src/plugins/ovirt-host-deploy/gluster/nrpe.py: Line 102: condition=lambda self: ( Line 103: self.environment[ Line 104: odeploycons.GlusterEnv.MONITORING_ENABLE Line 105: ] and Line 106: os.path.exists(odeploycons.FileLocations.NRPE_CONFIG_FILE) and > please check this last as it actually going to filesystem Done Line 107: self.environment[ Line 108: odeploycons.GlusterEnv.MONITORING_ENABLE Line 109: ] is not None Line 110: ), Line 106: os.path.exists(odeploycons.FileLocations.NRPE_CONFIG_FILE) and Line 107: self.environment[ Line 108: odeploycons.GlusterEnv.MONITORING_ENABLE Line 109: ] is not None Line 110: ), > this should be host Done Line 111: ) Line 112: def _misc(self): Line 113: with open(odeploycons.FileLocations.NRPE_CONFIG_FILE, 'r') as f: Line 114: content = f.read().splitlines() -- To view, visit http://gerrit.ovirt.org/26956 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4faa40e2bf382187907db944f7485c1630fcc0ae Gerrit-PatchSet: 5 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Darshan N <dnara...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Darshan N <dnara...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
