Darshan N has posted comments on this change. Change subject: gluster: Added a plugin under gluster for nrpe configuration. ......................................................................
Patch Set 4: (7 comments) http://gerrit.ovirt.org/#/c/26956/4/src/plugins/ovirt-host-deploy/gluster/nrpe.py File src/plugins/ovirt-host-deploy/gluster/nrpe.py: Line 1: # Line 2: # ovirt-host-deploy -- ovirt host deployer Line 3: # Copyright (C) 2012-2013 Red Hat, Inc. > please update Done Line 4: # Line 5: # This library is free software; you can redistribute it and/or Line 6: # modify it under the terms of the GNU Lesser General Public Line 7: # License as published by the Free Software Foundation; either Line 17: # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA Line 18: # Line 19: Line 20: Line 21: """gluster psackages plugin.""" > please update Done Line 22: Line 23: Line 24: import gettext Line 25: _ = lambda m: gettext.dgettext(message=m, domain='ovirt-host-deploy') Line 19: Line 20: Line 21: """gluster psackages plugin.""" Line 22: Line 23: > here: Done Line 24: import gettext Line 25: _ = lambda m: gettext.dgettext(message=m, domain='ovirt-host-deploy') Line 26: Line 27: Line 26: Line 27: Line 28: from otopi import util Line 29: from otopi import plugin Line 30: import os.path > remove Done Line 31: from ovirt_host_deploy import constants as odeploycons Line 32: from otopi import constants as otopicons Line 33: from otopi import filetransaction Line 34: import re Line 30: import os.path Line 31: from ovirt_host_deploy import constants as odeploycons Line 32: from otopi import constants as otopicons Line 33: from otopi import filetransaction Line 34: import re > remove Done Line 35: Line 36: Line 37: @util.export Line 38: class Plugin(plugin.PluginBase): Line 36: Line 37: @util.export Line 38: class Plugin(plugin.PluginBase): Line 39: def __init__(self, context): Line 40: super(Plugin, self).__init__(context=context) > minor issue... please move constructor after constants and private function Done Line 41: Line 42: """ Line 43: # sample nrpe config file format Line 44: # comment Line 100: stage=plugin.Stages.STAGE_MISC, Line 101: condition=lambda self: ( Line 102: self.environment[ Line 103: odeploycons.GlusterEnv.MONITORING_ENABLE Line 104: ] and > ok... sorry... now I also see that we should check if server is not None Done Line 105: os.path.exists(odeploycons.FileLocations.NRPE_CONFIG_FILE) Line 106: ), Line 107: ) Line 108: def _misc(self): -- To view, visit http://gerrit.ovirt.org/26956 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4faa40e2bf382187907db944f7485c1630fcc0ae Gerrit-PatchSet: 4 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Darshan N <dnara...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Darshan N <dnara...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
