Daniel Erez has posted comments on this change. Change subject: core: handle 'source' domains when adding a vm from template ......................................................................
Patch Set 5: (2 comments) http://gerrit.ovirt.org/#/c/26262/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/DiskImagesValidator.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/DiskImagesValidator.java: Line 190: * is null, it will be checked that there are no derived disks on any storage domain. Line 191: */ Line 192: public ValidationResult diskImagesOnAnyApplicableDomains(Map<Guid, Set<Guid>> validDomainsForDisk, Line 193: Map<Guid, StorageDomain> storageDomains, Line 194: VdcBllMessages message, Can the method provide a default message and accept a custom one for re-usability only when needed? Line 195: Set<StorageDomainStatus> applicableStatuses) { Line 196: Line 197: List<String> disksInfo = new LinkedList<>(); Line 198: for (DiskImage diskImage : diskImages) { Line 207: nonApplicableStorageInfo.add(String.format("%s - %s", domain.getName(), domain.getStatus() Line 208: .toString())); Line 209: } Line 210: Line 211: disksInfo.add(String.format("%s (%s) %n", Consider adding a comment with an example illustrating the final result of each string (cause it's a bit hard to follow..). E.g. 'Disk1 (SD1 - Active / ...) \n ...' Line 212: diskImage.getDiskAlias(), Line 213: StringUtils.join(nonApplicableStorageInfo, " / "))); Line 214: } Line 215: -- To view, visit http://gerrit.ovirt.org/26262 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8d02cfded41a3588dc944d9dfcd5a3eec88c45ab Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
