Allon Mureinik has posted comments on this change. Change subject: core: handle 'source' domains when adding a vm from template ......................................................................
Patch Set 5: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/26262/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java: Line 465: Line 466: public static Map<Guid, Set<Guid>> findDomainsInApplicableStatusForDisks(Iterable<DiskImage> diskImages, Line 467: Map<Guid, StorageDomain> storageDomains, Line 468: Set<StorageDomainStatus> applicableStatuses) { Line 469: Map<Guid, Set<Guid>> disksApplicableDomainsMap = new HashMap<>(); something seems off with the indentation - please double check it's not just a gerrit foobar. Line 470: for (DiskImage diskImage : diskImages) { Line 471: Set<Guid> diskApplicableDomain = new HashSet<>(); Line 472: disksApplicableDomainsMap.put(diskImage.getId(), diskApplicableDomain); Line 473: for (Guid storageDomainID : diskImage.getStorageIds()) { -- To view, visit http://gerrit.ovirt.org/26262 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8d02cfded41a3588dc944d9dfcd5a3eec88c45ab Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
