Martin Sivák has posted comments on this change. Change subject: use monotonic time when checking the timeouts ......................................................................
Patch Set 16: (1 comment) http://gerrit.ovirt.org/#/c/26384/16/ovirt_hosted_engine_ha/agent/state_machine.py File ovirt_hosted_engine_ha/agent/state_machine.py: Line 114: Line 115: # Prepare changes to the data structure Line 116: new_data = {} Line 117: # save the copy of alive_hosts right after we compute it to avoid Line 118: # any changes that might be done to the list Are you really sure this works? I think alive_hosts contains full host dictionaries here, but the brokerlink function expects a list of IDs only. Line 119: new_data["alive_hosts"] = list(alive_hosts) Line 120: Line 121: if alive_hosts: Line 122: # Pre-compute the best remote engine (skip old metadata -- To view, visit http://gerrit.ovirt.org/26384 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9794beb4082f52d29835be5b6a182ab448c248f2 Gerrit-PatchSet: 16 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák <jmosk...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmosk...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
