Martin Sivák has posted comments on this change. Change subject: use monotonic time when checking the timeouts ......................................................................
Patch Set 14: (1 comment) http://gerrit.ovirt.org/#/c/26384/14/ovirt_hosted_engine_ha/agent/state_machine.py File ovirt_hosted_engine_ha/agent/state_machine.py: Line 111: else: Line 112: alive_hosts = [] Line 113: Line 114: # update the list of alive hosts in broker Line 115: self.hosted_engine.update_hosts_state(alive_hosts) I think this should be moved to the same place where we publish the stats to the broker (hosted_engine.py:334). We could compute the data here and save the list of hosts to the HostedEngineData structure. That we can then use outside without exposing the internals. Line 116: Line 117: if alive_hosts: Line 118: # Pre-compute the best remote engine (skip old metadata Line 119: # for local host) -- To view, visit http://gerrit.ovirt.org/26384 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9794beb4082f52d29835be5b6a182ab448c248f2 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák <jmosk...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmosk...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
