mooli tayer has posted comments on this change.

Change subject: core: Add selinux host info to VdsDynamic
......................................................................


Patch Set 1:

(1 comment)

Getting close...

http://gerrit.ovirt.org/#/c/26955/1/packaging/dbscripts/upgrade/post_upgrade/0010_add_object_column_white_list_table.sql
File 
packaging/dbscripts/upgrade/post_upgrade/0010_add_object_column_white_list_table.sql:

Line 65: 
Line 66: -----------------------------------------------------
Line 67: -- Object white list modification section
Line 68: -- use fn_db_add_column_to_object_white_list(obj,col)
Line 69: -- to add new object columns to the white list
Is seems this comment says that you should move this to 
 db_add_column_to_object_white_list(
 'vds_dynamic', 'selinux_enforce_mode')
  in 03_05_0300_add_selinux_to_vds_dynamic.sql

Eli?
Line 70: -- since this script must remain reentrant
Line 71: -----------------------------------------------------
Line 72: 


-- 
To view, visit http://gerrit.ovirt.org/26955
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If472f68702b59280c721450d4db50dc27dc19a30
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuzn...@redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuzn...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer <mta...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to