Juan Hernandez has posted comments on this change. Change subject: core: Add selinux host info to VdsDynamic ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/26955/1/backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd File backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd: Line 1518: <xs:element name="libvirt_version" type="Version" minOccurs="0" maxOccurs="1"/> Line 1519: <!-- Optionally specify the display address of this host explicitly --> Line 1520: <xs:element ref="display" minOccurs="0"/> Line 1521: <xs:element name="hosted_engine" type="HostedEngine" minOccurs="0" maxOccurs="1"/> Line 1522: <xs:element name="selinux_enforce_mode" type="xs:int" minOccurs="0" maxOccurs="1" /> We may want to report additional information about SELinux in the future, like the name of the policy, so I think it is better if we represent this as follows: <selinux> <mode>enforcing|permissive|disabled</mode> </selinux> This way, if we need to extend we can do as follows: <selinux> <mode>enforcing|permissive|disabled</mode> <policy>targeted</policy> </selinux> Line 1523: </xs:sequence> Line 1524: </xs:extension> Line 1525: </xs:complexContent> Line 1526: </xs:complexType> -- To view, visit http://gerrit.ovirt.org/26955 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If472f68702b59280c721450d4db50dc27dc19a30 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
