Maor Lipchuk has posted comments on this change. Change subject: engine: Improve iSCSI Bond CDA validation ......................................................................
Patch Set 1: (3 comments) http://gerrit.ovirt.org/#/c/26931/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/BaseIscsiBondCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/BaseIscsiBondCommand.java: Line 31: super(commandId); Line 32: } Line 33: Line 34: @Override Line 35: protected boolean canDoAction() { Isn't checking the version is only enough for new iSCSI. perhaps we should not need to put this validation in the BaseIscsiBond but only in the new iSCSI command Line 36: if (!FeatureSupported.isIscsiMultipathingSupported(getStoragePool().getcompatibility_version())) { Line 37: return failCanDoAction(VdcBllMessages.ISCSI_BOND_NOT_SUPPORTED); Line 38: } Line 39: http://gerrit.ovirt.org/#/c/26931/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/EditIscsiBondCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/EditIscsiBondCommand.java: Line 34: } Line 35: Line 36: @Override Line 37: protected boolean canDoAction() { Line 38: if (!super.canDoAction()) { Why do we need to check if the iSCSI bond is supported if it is already exists in the Data Center? Line 39: return false; Line 40: } Line 41: Line 42: IscsiBondValidator validator = new IscsiBondValidator(); http://gerrit.ovirt.org/#/c/26931/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveIscsiBondCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveIscsiBondCommand.java: Line 16: } Line 17: Line 18: @Override Line 19: protected boolean canDoAction() { Line 20: if (!super.canDoAction()) { Why do we need to check if the iSCSI bond is supported if it is already exists in the Data Center? Line 21: return false; Line 22: } Line 23: Line 24: IscsiBondValidator validator = new IscsiBondValidator(); -- To view, visit http://gerrit.ovirt.org/26931 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d0ac7e6af6cb87b500740d679af2f13e63dbeb5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
