Lior Vernia has posted comments on this change. Change subject: webadmin: Set default vNIC type according to OsInfo ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/26925/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/BaseEditVmInterfaceModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/BaseEditVmInterfaceModel.java: Line 106: nicTypes = nicTypes == null ? new ArrayList<VmInterfaceType>() : nicTypes; Line 107: Line 108: if (selectedNicType == null || !nicTypes.contains(VmInterfaceType.forValue(selectedNicType))) Line 109: { Line 110: selectedNicType = AsyncDataProvider.getDefaultNicType(nicTypes).getValue(); > well, so now when the getDefaultNicType returns null it will fail on NPE he Done, corrected similar issue in VmInterfaceCreatingManager.java. Line 111: } Line 112: Line 113: getNicType().setSelectedItem(VmInterfaceType.forValue(selectedNicType)); Line 114: } -- To view, visit http://gerrit.ovirt.org/26925 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4f09986e661d820b3c10301fa35c840fd9cfe0d8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
