Lior Vernia has posted comments on this change.

Change subject: webadmin: Set default vNIC type according to OsInfo
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/26925/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java:

Line 3109:     }
Line 3110: 
Line 3111:     public static VmInterfaceType 
getDefaultNicType(Collection<VmInterfaceType> items)
Line 3112:     {
Line 3113:         return items.contains(VmInterfaceType.pv) ? 
VmInterfaceType.pv : items.iterator().next();
> According to logic in BaseEditVmInterfaceModel:
Done
Line 3114:     }
Line 3115: 
Line 3116:     public static boolean isVersionMatchStorageType(Version version, 
boolean isLocalType) {
Line 3117:         return version.compareTo(new Version(3, 0)) >= 0;


-- 
To view, visit http://gerrit.ovirt.org/26925
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4f09986e661d820b3c10301fa35c840fd9cfe0d8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to