David Caro has posted comments on this change.

Change subject: packaging: setup: Ask whether to backup the database
......................................................................


Patch Set 9:

(1 comment)

This commit is making the rpm creation fail, can you fis asap please?

Thanks!

http://gerrit.ovirt.org/#/c/26082/9/packaging/setup/ovirt_engine_setup/dwhconstants.py
File packaging/setup/ovirt_engine_setup/dwhconstants.py:

Line 221: RESTORE_BACKUP_LATE
This does not compile, it's lacking the parenthesis


-- 
To view, visit http://gerrit.ovirt.org/26082
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e113bddaeeb71b00f5a524db0be3a24fa6f9907
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-dwh
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: David Caro <dcaro...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com>
Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to