Alex Lourie has posted comments on this change. Change subject: packaging: Moving to use execCmd in all scripts (#731686) ......................................................................
Patch Set 2: (2 inline comments) .................................................... File packaging/fedora/setup/engine-setup.py Line 1003: cmd = ["/bin/sh", basedefs.DIR_DB_SCRIPTS + "/" + basedefs.FILE_DB_UPGRADE_SCRIPT] + dbScriptArgs We currently have no specific style guidelines, but I agree with this. This is not urgent, so I may do it in few patches over all the code we have. Line 1006: output, rc = utils.execCmd(cmd, None, True, output_messages.ERR_DB_UPGRADE_FAILED) Good point. I'll update the code. -- To view, visit http://gerrit.ovirt.org/4943 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5428890f9dcf8eafaa1ab059ee5d9e84f3f7f9a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: moran goldboim <mgold...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
