Martin Peřina has posted comments on this change. Change subject: tools: Remove debug log when parsing args in engine-config ......................................................................
Patch Set 4: The logging setup is executed after command line arguments are parsed. If you log something before logging is properly set up, log4j prints various warnings into stderr. So proper way how to handle this is not to use logger during cli args parsing. If some error occurres during parsing, it should be printed directly to console. Also logging inside EngineConfigCLIParser is used only for debugging puproses and it doesn't have any meaning for user. So that's why I want to remove. -- To view, visit http://gerrit.ovirt.org/26590 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b549b8216c3e1af2cf167fac978673c9528894d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
