Alon Bar-Lev has posted comments on this change.

Change subject: tools: Remove debug log when parsing args in engine-config
......................................................................


Patch Set 4:

I can just guess that this is egg and chicken... as you parse parameters for 
log you do not have log, not sure why we need to actual remove the code...

For early stage logging, environment vars can be used to setup early level and 
file, not sure this is required in this case.

-- 
To view, visit http://gerrit.ovirt.org/26590
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b549b8216c3e1af2cf167fac978673c9528894d
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to