Barak Azulay has posted comments on this change. Change subject: core: VMs moved to UNKNOWN after set to DOWN ......................................................................
Patch Set 2: Code-Review-1 2 comments: - rplying to Omer - True there may be a race between the monitoring thread and this flow, however the race is shorter (and it is a bit risky now to change it when host moved to non-operational) - Iterating through the VMs is a bit expensive as it goes to the DB for each VM ... May be a better way to handle this situation at this point is to add a stored procedure that will ipdate all VMs (that are not in DOWN status) at once and move them to UNKNOWN. This will eliminate the race. Eli what do you think ? -- To view, visit http://gerrit.ovirt.org/26466 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c6a6b67e4ec8b44a41dc13729b5999b852a88e2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
