Martin Peřina has posted comments on this change. Change subject: core: VMs moved to UNKNOWN after set to DOWN ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/26466/4/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAODbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAODbFacadeImpl.java: Line 443: } Line 444: } Line 445: Line 446: @Override Line 447: public List<VM> getMultipleVMs(List<Guid> ids){ Will this method be reused? If not, wouldn't it be better/faster to write just this stored procedure: SELECT COUNT(vm_guid) FROM vms WHERE vm_status <> v_status AND vm_guid = any(v_vm_guids) and test only if count > 0 Line 448: Log log = LogFactory.getLog(getClass()); Line 449: Array idArray=null; Line 450: try { Line 451: idArray = jdbcTemplate.getDataSource().getConnection().createArrayOf("uuid", ids.toArray()); -- To view, visit http://gerrit.ovirt.org/26466 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c6a6b67e4ec8b44a41dc13729b5999b852a88e2 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
