Maor Lipchuk has posted comments on this change. Change subject: engine: Remove address from hotunplugged devices ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/26598/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommand.java: Line 139: getVmStaticDAO().incrementDbGeneration(getVm().getId()); Line 140: setSucceeded(true); Line 141: } Line 142: Line 143: protected void updateDeviceProperties() { You might want to change this method signature to be added with device parameter, so you will be able to call the super method with the vmDevice. as so : protected void updateDeviceProperties(VmDevice device) that way you can change the relevant logic for unplug in the HotUnPlugDisk..Command, and still use the existing logic of updateHotPlugDisk Line 144: VmDevice device = getVmDeviceDao().get(oldVmDevice.getId()); Line 145: device.setIsPlugged(!oldVmDevice.getIsPlugged()); Line 146: getVmDeviceDao().updateHotPlugDisk(device); Line 147: } -- To view, visit http://gerrit.ovirt.org/26598 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id5850fd4c15a230dbc27e8c22d47935083da21c2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Xavi Francisco <xfran...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
