Maor Lipchuk has posted comments on this change. Change subject: engine: Remove address from hotunplugged devices ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/26598/1//COMMIT_MSG Commit Message: Line 11: Line 12: The rationale behind this is: when a disk is hotunplugged qemu may free the Line 13: disk's address for further use. If another disk is hotplugged that Line 14: address may be given to the new device. Thus would cause that when the Line 15: first disk is hotplugged again it's address will be rejected because /s/it's/its Line 16: it's in use by the second disk. Line 17: Line 18: Change-Id: Id5850fd4c15a230dbc27e8c22d47935083da21c2 Line 19: Bug-Url: https://bugzilla.redhat.com/1079697 http://gerrit.ovirt.org/#/c/26598/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommand.java: Line 144: VmDevice device = getVmDeviceDao().get(oldVmDevice.getId()); Line 145: device.setIsPlugged(!oldVmDevice.getIsPlugged()); Line 146: if (!device.getIsPlugged()) { Line 147: device.setAddress(""); Line 148: } perhaps you can override this method in HotUnPlugDiskFromVmCommand, and only set the address there with empty string. Line 149: getVmDeviceDao().updateHotPlugDisk(device); Line 150: } Line 151: Line 152: private void updateBootOrder() { -- To view, visit http://gerrit.ovirt.org/26598 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id5850fd4c15a230dbc27e8c22d47935083da21c2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Xavi Francisco <xfran...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
