Alon Bar-Lev has posted comments on this change. Change subject: core: integrate make into maven ......................................................................
Patch Set 2: (3 comments) http://gerrit.ovirt.org/#/c/25661/2/mavenmake/pom.xml File mavenmake/pom.xml: Line 13: <name>ovirt engine maven make</name> Line 14: <description>ovirt engine maven make</description> Line 15: Line 16: <properties> Line 17: <devenv.prefix>${env.PREFIX}</devenv.prefix> oh.. just saw that... PREFIX is the name of the variable? if so better have OVIRT_DEVENV_PREFIX to not conflict with other keys. Line 18: </properties> Line 19: Line 20: <profiles> Line 21: <profile> Line 43: <workingDirectory>${project.parent.basedir}</workingDirectory> Line 44: <arguments> Line 45: <argument>install-dev</argument> Line 46: <argument>PREFIX=${devenv.prefix}</argument> Line 47: <argument>DEV_REBUILD=0</argument> > Doesn't DEV_REBUILD=0 mean that compilation will be skipped ? Is that the d yes, this is the entire idea... as maven already built binaries. Line 48: </arguments> Line 49: </configuration> Line 50: </plugin> Line 51: </plugins> Line 44: <arguments> Line 45: <argument>install-dev</argument> Line 46: <argument>PREFIX=${devenv.prefix}</argument> Line 47: <argument>DEV_REBUILD=0</argument> Line 48: </arguments> > would it be possible to add another argument "DEV_EXTRA_BUILD_FLAGS", so an good idea, should be also via environment as devenv.prefix. Line 49: </configuration> Line 50: </plugin> Line 51: </plugins> Line 52: </build> -- To view, visit http://gerrit.ovirt.org/25661 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8981f04b26a2d36429f8bfccaada8dfbadfbf9c3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
