Moti Asayag has posted comments on this change. Change subject: core: integrate make into maven ......................................................................
Patch Set 2: (4 comments) http://gerrit.ovirt.org/#/c/25661/2/mavenmake/pom.xml File mavenmake/pom.xml: Line 20: <profiles> Line 21: <profile> Line 22: <id>make</id> Line 23: </profile> Line 24: </profiles> please add a space line Line 25: <build> Line 26: Line 27: <plugins> Line 28: <plugin> Line 22: <id>make</id> Line 23: </profile> Line 24: </profiles> Line 25: <build> Line 26: and remove this one Line 27: <plugins> Line 28: <plugin> Line 29: <groupId>org.codehaus.mojo</groupId> Line 30: <artifactId>exec-maven-plugin</artifactId> Line 43: <workingDirectory>${project.parent.basedir}</workingDirectory> Line 44: <arguments> Line 45: <argument>install-dev</argument> Line 46: <argument>PREFIX=${devenv.prefix}</argument> Line 47: <argument>DEV_REBUILD=0</argument> Doesn't DEV_REBUILD=0 mean that compilation will be skipped ? Is that the default we'd like for this profile? Line 48: </arguments> Line 49: </configuration> Line 50: </plugin> Line 51: </plugins> Line 44: <arguments> Line 45: <argument>install-dev</argument> Line 46: <argument>PREFIX=${devenv.prefix}</argument> Line 47: <argument>DEV_REBUILD=0</argument> Line 48: </arguments> would it be possible to add another argument "DEV_EXTRA_BUILD_FLAGS", so any practiced maven command will be applied here as well. >From the README.developer: DEV_EXTRA_BUILD_FLAGS Any maven build flags requires for building. For example, if your machine is low on memory, use: DEV_EXTRA_BUILD_FLAGS="-Dgwt.compiler.localWorkers=2" Line 49: </configuration> Line 50: </plugin> Line 51: </plugins> Line 52: </build> -- To view, visit http://gerrit.ovirt.org/25661 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8981f04b26a2d36429f8bfccaada8dfbadfbf9c3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
