Jiří Moskovčák has posted comments on this change. Change subject: packaging: setup: storage: refactored plugin ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/26488/2/src/plugins/ovirt-hosted-engine-setup/storage/nfs.py File src/plugins/ovirt-hosted-engine-setup/storage/nfs.py: Line 106: ), Line 107: raiseOnError=False Line 108: ) Line 109: if rc == 0: Line 110: tries = -1 how about using for _try in xrange(0, self.UMOUNT_TRIES) cycle and break here, you won't have to care about decreasing the tries Line 111: else: Line 112: tries -= 1 Line 113: time.sleep(1) Line 114: # rc, stdout and stderr are automatically logged as debug -- To view, visit http://gerrit.ovirt.org/26488 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ided3e1f8e71abc2d0e3ec80e1cd2c2f3cca1f1df Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmosk...@redhat.com> Gerrit-Reviewer: Lev Veyde <lve...@gmail.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
