Jiří Moskovčák has posted comments on this change. Change subject: packaging: setup: storage: refactored plugin ......................................................................
Patch Set 1: Code-Review-1 (2 comments) http://gerrit.ovirt.org/#/c/26488/1/src/plugins/ovirt-hosted-engine-setup/storage/nfs.py File src/plugins/ovirt-hosted-engine-setup/storage/nfs.py: Line 55: fstype = '' Line 56: opts = [] Line 57: Line 58: if domain_type == 'nfs3': Line 59: fstype = 'nfs' use a constant for the 'nfs' literal Line 60: opts.append('vers=3') Line 61: elif domain_type == 'nfs4': Line 62: fstype = 'nfs' Line 63: opts.append('vers=4') http://gerrit.ovirt.org/#/c/26488/1/src/plugins/ovirt-hosted-engine-setup/storage/storage.py File src/plugins/ovirt-hosted-engine-setup/storage/storage.py: Line 678: validValues=( Line 679: # Enable when glusterfs issues are solved: Line 680: # 'glusterfs', Line 681: 'nfs3', Line 682: 'nfs4', and also please use a constant for 'nfs3' and 'nfs4' and 'glusterfs' Line 683: ), Line 684: default='nfs3', Line 685: ) Line 686: -- To view, visit http://gerrit.ovirt.org/26488 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ided3e1f8e71abc2d0e3ec80e1cd2c2f3cca1f1df Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmosk...@redhat.com> Gerrit-Reviewer: Lev Veyde <lve...@gmail.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
