Maor Lipchuk has posted comments on this change. Change subject: core: extract SnapshotsEngineLock to BaseImagesCommand ......................................................................
Patch Set 4: Code-Review+2 (1 comment) minor comment regarding formatting http://gerrit.ovirt.org/#/c/26325/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java: Line 247: return result; Line 248: } Line 249: Line 250: /** Line 251: * Prepare a single {@link org.ovirt.engine.core.common.businessentities.Snapshot} object representing a snapshot of a given VM without the give disk. Use formatter here Line 252: */ Line 253: protected Snapshot prepareSnapshotConfigWithoutImageSingleImage(Guid vmSnapshotId, Guid imageId) { Line 254: Snapshot snap = null; Line 255: try { -- To view, visit http://gerrit.ovirt.org/26325 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idc4b46a2c53a0ec6ac13c1dba73089ae4512bea7 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
