Liron Ar has posted comments on this change. Change subject: core: extract SnapshotsEngineLock to BaseImagesCommand ......................................................................
Patch Set 5: Code-Review+1 (2 comments) minor comment regarding member placement and TWS. http://gerrit.ovirt.org/#/c/26325/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java: Line 151: protected void setImageGroupId(Guid value) { Line 152: _imageGroupId = value; Line 153: } Line 154: Line 155: private EngineLock snapshotsEngineLock; please move to where other members are defined Line 156: Line 157: protected EngineLock getSnapshotsEngineLock() { Line 158: return snapshotsEngineLock; Line 159: } http://gerrit.ovirt.org/#/c/26325/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java: Line 245: } Line 246: Line 247: return result; Line 248: } Line 249: TWS Line 250: /** Line 251: * Prepare a single {@link org.ovirt.engine.core.common.businessentities.Snapshot} object representing a snapshot of a given VM without the give disk. Line 252: */ Line 253: protected Snapshot prepareSnapshotConfigWithoutImageSingleImage(Guid vmSnapshotId, Guid imageId) { -- To view, visit http://gerrit.ovirt.org/26325 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idc4b46a2c53a0ec6ac13c1dba73089ae4512bea7 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
