Yaniv Bronhaim has posted comments on this change. Change subject: core: Host's Compatibility Version doesn't match the Cluster's Compatibility Version ......................................................................
Patch Set 7: (1 comment) http://gerrit.ovirt.org/#/c/26061/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HandleVdsVersionCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HandleVdsVersionCommand.java: Line 58: } Line 59: Line 60: // Check if vdsm supports the current engine, and that it supports the cluster version Line 61: if (!isEngineSupportedByVdsm) { Line 62: reportNonOperationReason(NonOperationalReason.VERSION_INCOMPATIBLE_WITH_CLUSTER, errr, probably i confused you. all i meant is to have the right report here.. VERSION_INCOMPATIBLE_WITH_CLUSTER is about cluster level, when we check here supportedEngine by vdsm (not related to cluster at all). for that i wanted new constant name and string. Line 63: partialVdcVersion.toString(), Line 64: vdsmVersion.toString()); Line 65: } Line 66: else if (!VersionSupport.checkClusterVersionSupported(cluster.getcompatibility_version(), vds)) { -- To view, visit http://gerrit.ovirt.org/26061 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a899462ce3d74f3b1570a23c10ce38aeae1a18e Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
