Liran Zelkha has posted comments on this change. Change subject: core: Host's Compatibility Version doesn't match the Cluster's Compatibility Version ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/26061/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HandleVdsVersionCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HandleVdsVersionCommand.java: Line 61: // vdsm supprtedEngineVersions list) we move on and check if engine Line 62: // and cluster supports the specific vdsm version. which is sufficient Line 63: if (!isEngineSupportedByVdsm) { Line 64: reportNonOperationReason(NonOperationalReason.VERSION_INCOMPATIBLE_WITH_CLUSTER, Line 65: partialVdcVersion.toString(), > i think it worth changing also VERSION_INCOMPATIBLE_WITH_CLUSTER to somethi Done Line 66: vdsmVersion.toString()); Line 67: } Line 68: else if (!VersionSupport.checkClusterVersionSupported(cluster.getcompatibility_version(), vds)) { Line 69: reportNonOperationReason(NonOperationalReason.CLUSTER_VERSION_INCOMPATIBLE_WITH_CLUSTER, -- To view, visit http://gerrit.ovirt.org/26061 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a899462ce3d74f3b1570a23c10ce38aeae1a18e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
