Eli Mesika has posted comments on this change. Change subject: core: VMs moved to UNKNOWN after set to DOWN ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/26466/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsNotRespondingTreatmentCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsNotRespondingTreatmentCommand.java: Line 105: log.errorFormat("Failed to run Fence script on vds:{0}, VMs moved to UnKnown instead.", getVdsName()); Line 106: AlertIfPowerManagementOperationSkipped(RESTART, null); Line 107: } Line 108: Line 109: private boolean vmNotInStatusExists(VMStatus status) { > this method will never return false, if it does, please show me how you did oppsss, had to get that from DB since the vm list exists but status may already changed in DB Line 110: for (VM vm : getVmList()) { Line 111: if (vm.getStatus() != status) Line 112: return true; Line 113: } -- To view, visit http://gerrit.ovirt.org/26466 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c6a6b67e4ec8b44a41dc13729b5999b852a88e2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
