Mike Kolesnik has submitted this change and it was merged. Change subject: core: Add validation to MAC format (#756437) ......................................................................
core: Add validation to MAC format (#756437) https://bugzilla.redhat.com/756437 The MAC address needs to be in a specific format, so adding a validation so that when network is created/updated then the MAC address format is correct. The validation of MAC size is no longer required, since this new validation will cover also shorter/longer MAC cases. A dependency on slf4j-nop was added to the pom.xml file for scope test to allow testing the validations, since the default validation provider uses slf4j so we must provide some implementation. Change-Id: I8d25cc5c48fb2ab48c9137cd167a43459cf03931 Signed-off-by: Mike Kolesnik <mkole...@redhat.com> --- M backend/manager/modules/common/pom.xml M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/BusinessEntitiesDefinitions.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/NetworkInterface.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmNetworkInterface.java A backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/businessentities/VmNetworkInterfaceValidationTest.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/utils/pom.xml M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 11 files changed, 111 insertions(+), 4 deletions(-) Approvals: Mike Kolesnik: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4375 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8d25cc5c48fb2ab48c9137cd167a43459cf03931 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
