Sharad Mishra has posted comments on this change. Change subject: engine: Allow to iterate over remaining ldap servers on NullPointerException. ......................................................................
Patch Set 2: (1 inline comment) .................................................... File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/JndiAction.java Line 167: guidString = null; I am unable to open the links. I agree that NPE can come from other sources. This try/catch block is getting the guid string. So even if, NPE comes for what ever reason, we are printing the message, setting guid to null and proceeding forward. In general, I agree that NPE should not be caught, but I think we are okay in this case. Yair, Oved - comments ? -- To view, visit http://gerrit.ovirt.org/4439 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1088dc1a5852759375422e5e97556ee01b16c56 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmis...@linux.vnet.ibm.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ryan Harper <ry...@us.ibm.com> Gerrit-Reviewer: Sharad Mishra <snmis...@linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
