Yair Zaslavsky has posted comments on this change.
Change subject: engine: Allow to iterate over remaining ldap servers on
NullPointerException.
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
Sharad - minor comment,
Besides that looks good.
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/JndiAction.java
Line 169: System.out.println("LDAP connection successful. But no
guid found");
Hi Sharad,
I don't remember what was the original text here (at your original patch, but
what about explaining what is this guid. For example, maybe , "But no user ID
found"?
Besides that the patch looks good, this is merely a suggestion.
--
To view, visit http://gerrit.ovirt.org/5148
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf89ef5d423cde2e420d6196b38506a23416abb8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharad Mishra <snmis...@linux.vnet.ibm.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
